Re: [PATCH v4] x86/entry: emit a symbol for register restoring thunk
flat view
From: Mark Brown <broonie@kernel.org>
Date: 2021-01-12 21:51:11
Also in:
lkml
On Tue, Jan 12, 2021 at 11:46:24AM -0800, Nick Desaulniers wrote: This:
when building with LLVM_IAS=1 (Clang's integrated assembler). Josh notes:
So basically, you can use an .L symbol *inside* a function or a code segment, you just can't use the .L symbol to contain the code using a SYM_*_START/END annotation pair.
is a stronger statement than this:
quoted hunk ↗ jump to hunk
+ Developers should avoid using local symbol names that are prefixed with + ``.L``, as this has special meaning for the assembler; a symbol entry will + not be emitted into the symbol table. This can prevent ``objtool`` from + generating correct unwind info. Symbols with STB_LOCAL binding may still be + used, and ``.L`` prefixed local symbol names are still generally useable + within a function, but ``.L`` prefixed local symbol names should not be used + to denote the beginning or end of code regions via + ``SYM_CODE_START_LOCAL``/``SYM_CODE_END``.
and seems more what I'd expect - SYM_FUNC* is also affected for example. Even though other usages are probably not very likely it seems better to keep the stronger statement in case someone comes up with one, and to stop anyone spending time wondering why only SYM_CODE_START_LOCAL is affected. This also looks like a good candiate for a checkpatch rule, but that can be done separately of course.
Attachments
- signature.asc [application/pgp-signature] 488 bytes