Re: [PATCH v3 5/6] mm/gup: migrate pinned pages out of movable zone
From: Jason Gunthorpe <jgg@ziepe.ca>
Date: 2020-12-11 21:29:46
Also in:
linux-mm, lkml
On Fri, Dec 11, 2020 at 03:21:39PM -0500, Pavel Tatashin wrote:
quoted hunk ↗ jump to hunk
@@ -1593,7 +1592,7 @@ static long check_and_migrate_cma_pages(struct mm_struct *mm, } if (!isolate_lru_page(head)) { - list_add_tail(&head->lru, &cma_page_list); + list_add_tail(&head->lru, &movable_page_list); mod_node_page_state(page_pgdat(head), NR_ISOLATED_ANON + page_is_file_lru(head),@@ -1605,7 +1604,7 @@ static long check_and_migrate_cma_pages(struct mm_struct *mm, i += step; } - if (!list_empty(&cma_page_list)) { + if (!list_empty(&movable_page_list)) {
You didn't answer my earlier question, is it OK that ZONE_MOVABLE pages leak out here if ioslate_lru_page() fails but the moval_page_list is empty? I think the answer is no, right? Jason