Thread (54 messages) 54 messages, 4 authors, 2020-11-17

Re: [External] Re: [PATCH v3 04/21] mm/hugetlb: Introduce nr_free_vmemmap_pages in the struct hstate

From: Muchun Song <hidden>
Date: 2020-11-11 03:23:04
Also in: linux-fsdevel, linux-mm, lkml

On Wed, Nov 11, 2020 at 3:40 AM Mike Kravetz [off-list ref] wrote:
On 11/9/20 6:42 PM, Muchun Song wrote:
quoted
On Tue, Nov 10, 2020 at 12:48 AM Oscar Salvador [off-list ref] wrote:
quoted
On Sun, Nov 08, 2020 at 10:10:56PM +0800, Muchun Song wrote:

Unrelated to this patch but related in general, I am not sure about Mike but
would it be cleaner to move all the vmemmap functions to hugetlb_vmemmap.c?
hugetlb code is quite tricky, so I am not sure about stuffing more code
in there.
I also think that you are right, moving all the vmemmap functions to
hugetlb_vmemmap.c may make the code cleaner.

Hi Mike, what's your opinion?
I would be happy to see this in a separate file.  As Oscar mentions, the
hugetlb.c file/code is already somethat difficult to read and understand.
Got it. I will do this. Thanks.
--
Mike Kravetz


-- 
Yours,
Muchun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help