Re: [PATCH v3 01/10] mm: add Kernel Electric-Fence infrastructure

From
Alexander Potapenko <glider@google.com>
Date
2020-10-05 16:01:14
Also in
linux-arm-kernel, linux-mm, lkml
Reply to
Mark Rutland, 2020-09-29
On Tue, Sep 29, 2020 at 5:06 PM Mark Rutland [off-list ref] wrote:
On Tue, Sep 29, 2020 at 04:51:29PM +0200, Marco Elver wrote:
quoted
On Tue, 29 Sep 2020 at 16:24, Mark Rutland [off-list ref] wrote:
[...]
quoted
From other sub-threads it sounds like these addresses are not part of
the linear/direct map. Having kmalloc return addresses outside of the
linear map is going to break anything that relies on virt<->phys
conversions, and is liable to make DMA corrupt memory. There were
problems of that sort with VMAP_STACK, and this is why kvmalloc() is
separate from kmalloc().

Have you tested with CONFIG_DEBUG_VIRTUAL? I'd expect that to scream.

I strongly suspect this isn't going to be safe unless you always use an
in-place carevout from the linear map (which could be the linear alias
of a static carevout).
That's an excellent point, thank you! Indeed, on arm64, a version with
naive static-pool screams with CONFIG_DEBUG_VIRTUAL.

We'll try to put together an arm64 version using a carveout as you suggest.
Great, thanks!

Just to be clear, the concerns for DMA and virt<->phys conversions also
apply to x86 (the x86 virt<->phys conversion behaviour is more forgiving
in the common case, but still has cases that can go wrong).
To clarify, shouldn't kmalloc/kmem_cache allocations used with DMA be
allocated with explicit GFP_DMA?
If so, how practical would it be to just skip such allocations in
KFENCE allocator?
Thread (50 messages) 50 messages, 9 authors, last reply 2020-10-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help