Re: [PATCH -next] Documentation/vm: fix tables in arch_pgtable_helpers
From: Anshuman Khandual <hidden>
Date: 2020-07-08 05:10:14
Also in:
linux-arch, linux-mm, lkml
On 07/08/2020 07:36 AM, Randy Dunlap wrote:
On 7/7/20 6:22 PM, Anshuman Khandual wrote:quoted
On 07/08/2020 06:37 AM, Randy Dunlap wrote:quoted
From: Randy Dunlap <redacted> Make the tables be presented as tables in the generated output files (the line drawing did not present well). Signed-off-by: Randy Dunlap <redacted> Cc: Jonathan Corbet <corbet@lwn.net> Cc: linux-doc@vger.kernel.org Cc: Anshuman Khandual <redacted> Cc: Mike Rapoport <rppt@kernel.org> Cc: linux-arch@vger.kernel.org Cc: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org> --- Documentation/vm/arch_pgtable_helpers.rst | 333 ++++++-------------- 1 file changed, 116 insertions(+), 217 deletions(-)Do you have a git URL some where to see these new output ? This documentation is also useful when reading from a terminal where these manual line drawing tables make sense.No, I don't have a git URL. You can go to https://drive.google.com/file/d/1FO6lCRKldzESwLdylvY8tw10dOBvwz84/view?usp=sharing I had to Download the file and then view it locally. I couldn't get Google Drive to display it for me as html (only as text).
I could see it locally as well on a browser and the table looks the same way like those current manual ones on a terminal, so looks good to me.
I understand about reading tables at a terminal. This file could have been a txt file for that, but it's not. It's a RsT file.
Thats right. All files in Documentation/vm/ are .rst type, hence would not like to have a .txt type in there.
If you want to leave it as is, please fix these warnings:
Thats right. Can not have in both ways. Lets stick with .rst and change as required.