Thread (7 messages) 7 messages, 3 authors, 2020-03-11

Re: [PATCH v6 kunit-next 3/4] kunit: subtests should be indented 4 spaces according to TAP

From: Brendan Higgins <hidden>
Date: 2020-03-11 22:53:23
Also in: linux-kselftest, lkml

On Wed, Mar 4, 2020 at 3:07 AM Alan Maguire [off-list ref] wrote:
Introduce KUNIT_INDENT macro which corresponds to 4-space indentation,
and use it to modify indentation from tab to 4 spaces.

Suggested-by: Frank Rowand <redacted>
Signed-off-by: Alan Maguire <redacted>
Sorry for the late comment.

This change looks good except for one thing: kunit_tool
(tools/testing/kunit/kunit.py) expects the wrong indentation. Can you
fix it? I think it would be best to fix it in this change so that
there is point at which it is broken.

Currently, this change breaks it. For example, with
CONFIG_KUNIT_TEST=y and CONFIG_KUNIT_EXAMPLE_TEST=y. kunit_tool
reports the following:

Testing complete. 0 tests run. 0 failed. 0 crashed.

I am pretty sure the change needs to happen in
tools/testing/kunit/kunit_parser.py.

Cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help