Re: [PATCH v3 02/12] mm/gup: split get_user_pages_remote() into two routines

On 2/3/20 6:20 AM, Jan Kara wrote:

On Fri 31-01-20 19:40:19, John Hubbard wrote:

quoted

An upcoming patch requires reusing the implementation of
get_user_pages_remote(). Split up get_user_pages_remote() into an outer
routine that checks flags, and an implementation routine that will be
reused. This makes subsequent changes much easier to understand.

There should be no change in behavior due to this patch.

Signed-off-by: John Hubbard <jhubbard@nvidia.com>

Looks good to me. You can add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

Thanks for reviewing this series (sort of again), Jan! 


thanks,
-- 
John Hubbard
NVIDIA