Re: [PATCH 2/2] fbdev: fbmem: allow overriding the number of bootup logos

On 2019-08-24 17:34, Matthew Wilcox wrote:

On Fri, Aug 23, 2019 at 08:47:47AM +0000, Peter Rosin wrote:

quoted

+++ b/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbmem.c

@@ -56,6 +56,9 @@ EXPORT_SYMBOL(num_registered_fb);
 bool fb_center_logo __read_mostly;
 EXPORT_SYMBOL(fb_center_logo);
 
+unsigned int fb_logo_count __read_mostly;
+EXPORT_SYMBOL(fb_logo_count);

Why does this symbol need to be exported?  As I read the Makefile, fbcon
and fbmem are combined into the same module, so while the symbol needs
to be non-static, it doesn't need to be exported to other modules.

I guess you are right. I'll send a v2 tomorrow with an added patch to
unexport the fb_center_logo variable while at it...

Thanks for the feedback.

Cheers,
Peter