Re: [PATCH v2 1/2] Documentation: sphinx: Add missing comma to list of strings

From
Jonathan Corbet <corbet@lwn.net>
Date
2019-08-12 20:56:15
Also in
lkml
Reply to
Jonathan Neuschäfer, 2019-08-12
On Mon, 12 Aug 2019 18:07:04 +0200
Jonathan Neuschäfer [off-list ref] wrote:
quoted hunk ↗ jump to hunk
In Python, like in C, when a comma is omitted in a list of strings, the
two strings around the missing comma are concatenated.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---

v2:
- new patch
---
 Documentation/sphinx/automarkup.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/sphinx/automarkup.py b/Documentation/sphinx/automarkup.py
index 77e89c1956d7..a8798369e8f7 100644
--- a/Documentation/sphinx/automarkup.py
+++ b/Documentation/sphinx/automarkup.py
@@ -25,7 +25,7 @@ RE_function = re.compile(r'([\w_][\w\d_]+\(\))')
 # to the creation of incorrect and confusing cross references.  So
 # just don't even try with these names.
 #
-Skipfuncs = [ 'open', 'close', 'read', 'write', 'fcntl', 'mmap'
+Skipfuncs = [ 'open', 'close', 'read', 'write', 'fcntl', 'mmap',
               'select', 'poll', 'fork', 'execve', 'clone', 'ioctl']
Hmm...that's a wee bit embarrassing.  Applied (and the socket() patch
too), thanks.

jon
Thread (4 messages) 4 messages, 3 authors, last reply 2019-08-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help