Re: [PATCH 3/3] docs: Use underscore not hyphen in label
From: Jonathan Corbet <corbet@lwn.net>
Date: 2019-02-01 23:03:12
From: Jonathan Corbet <corbet@lwn.net>
Date: 2019-02-01 23:03:12
On Fri, 1 Feb 2019 07:56:08 +1100 "Tobin C. Harding" [off-list ref] wrote:
quoted
quoted
From: "Tobin C. Harding" <tobin@kernel.org> sphinx emits warning WARNING: undefined label: memory-allocation ...Weird, for me it works fine. The generated html at kernel.org [1] also seems to be Ok... What version of sphinx do you use?Thanks for looking at this Mike. I was running 1.4, I see there is a v2 out so I'll upgrade but if the warning doesn't show for you then I'd say we just drop this patch. Jon, Is it within your usual workflow to take just the first two patches from this series or would you like me to spin another version without the final patch in it?
We currently document that 1.4 is supposed to work, so we should stick to that; I think I'll go ahead and apply all three patches. We should maybe consider dragging our minimum version forward a bit, or else we might want to document this particular gotcha. Thanks, jon