Thread (23 messages) 23 messages, 4 authors, 2019-01-15

Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation

From: Dave Anderson <hidden>
Date: 2019-01-14 18:58:36
Also in: kexec, lkml


----- Original Message -----
On Mon, Jan 14, 2019 at 05:48:48PM +0000, Kazuhito Hagio wrote:
quoted
As for makedumpfile, it will be not impossible to remove the
init_uts_ns.name.relase (OSRELEASE), but some fixes are needed.
Because historically OSRELEASE has been a kind of a mandatory entry
in vmcoreinfo from the beginning of vmcoreinfo, so makedumpfile uses
its existence to check whether a vmcoreinfo is sane.
Well, init_uts_ns is exported in vmcoreinfo anyway - makedumpfile
can simply test init_uts_ns.name.release just as well. And the
"historically" argument doesn't matter because vmcoreinfo is not an ABI.

So makedumpfile needs to be changed to check that new export.
quoted
Also, I think crash also will need to be fixed if it is removed.
Preferably it would be left as-is.  The crash utility has a "crash --osrelease vmcore"
option that only looks at the dumpfile header, and just dump the string.  With respect
to compressed kdumps, crash could alternatively look at the utsname data that is stored
in the diskdump_header.utsname field, but with ELF vmcores, there is no such back-up.
What's the problem with leaving it alone?

Dave

Yes, I'm expecting user tools to be fixed and then exports removed.

--
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help