Re: [PATCH V4 4/5] misc/pvpanic: add support to get pvpanic device info by FDT
From: Andy Shevchenko <hidden>
Date: 2018-10-29 11:37:33
Also in:
lkml, platform-driver-x86
On Mon, Oct 29, 2018 at 5:22 AM Peng Hao [off-list ref] wrote:
By default, when ACPI tables and FDT coexist for ARM64, current kernel takes precedence over FDT to get device information. Virt machine in qemu provides both FDT and ACPI table. This patch increases the way to get information through FDT.
This one looks good to me! Though, see one comment below.
quoted hunk ↗ jump to hunk
Signed-off-by: Peng Hao <redacted> --- drivers/misc/pvpanic.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 62 insertions(+), 1 deletion(-)diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c index cfd7fef..eb1ed0f 100644 --- a/drivers/misc/pvpanic.c +++ b/drivers/misc/pvpanic.c@@ -3,15 +3,19 @@ * Pvpanic Device Support * * Copyright (C) 2013 Fujitsu. + * Copyright (C) 2018 ZTE. */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +#include <linux/platform_device.h> +#include <linux/of_address.h> #include <linux/kernel.h>
#include <linux/module.h> #include <linux/init.h>
Side note: one of the above is redundant (either it can be built as module -> module.h or not -> init.h)
#include <linux/types.h> #include <linux/acpi.h> +#include <linux/of.h>
I think alphabetical order is slightly better, though there are developers who think differently.
quoted hunk ↗ jump to hunk
MODULE_AUTHOR("Hu Tao [off-list ref]"); MODULE_DESCRIPTION("pvpanic device driver");@@ -60,6 +64,32 @@ .priority = 1, /* let this called before broken drm_fb_helper */ }; +static int pvpanic_mmio_probe(struct platform_device *pdev) +{ + struct resource *mem; + + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!mem) + return -EINVAL; + + base = devm_ioremap_resource(&pdev->dev, mem); + if (base == NULL) + return -EFAULT; + + atomic_notifier_chain_register(&panic_notifier_list, + &pvpanic_panic_nb); + + return 0; +} + +static int pvpanic_mmio_remove(struct platform_device *pdev) +{ + + atomic_notifier_chain_unregister(&panic_notifier_list, + &pvpanic_panic_nb); + + return 0; +} static acpi_status pvpanic_walk_resources(struct acpi_resource *res, void *context)@@ -118,4 +148,35 @@ static int pvpanic_remove(struct acpi_device *device) return 0; } -module_acpi_driver(pvpanic_driver); +static const struct of_device_id pvpanic_mmio_match[] = { + { .compatible = "qemu,pvpanic-mmio", }, + {} +}; + +static struct platform_driver pvpanic_mmio_driver = { + .driver = { + .name = "pvpanic-mmio", + .of_match_table = pvpanic_mmio_match, + }, + .probe = pvpanic_mmio_probe, + .remove = pvpanic_mmio_remove, +}; + +static int __init pvpanic_mmio_init(void) +{ + if (acpi_disabled) + return platform_driver_register(&pvpanic_mmio_driver); + else + return acpi_bus_register_driver(&pvpanic_driver); +} + +static void __exit pvpanic_mmio_exit(void) +{ + if (acpi_disabled) + platform_driver_unregister(&pvpanic_mmio_driver); + else + acpi_bus_unregister_driver(&pvpanic_driver); +} + +module_init(pvpanic_mmio_init); +module_exit(pvpanic_mmio_exit); --1.8.3.1
-- With Best Regards, Andy Shevchenko