Thread (5 messages) 5 messages, 2 authors, 2018-10-01

Re: [PATCH v2 0/3] gpio: Fix VLA removal fallout

From: Linus Walleij <hidden>
Date: 2018-10-01 10:24:34
Also in: linux-gpio, lkml

On Thu, Sep 27, 2018 at 1:38 PM Geert Uytterhoeven
[off-list ref] wrote:
This patch series fixes various (mostly harmless) issues introduced by
commit 3027743f83f867d8 ("gpio: Remove VLA from gpiolib").

As per the "one patch should fix one issue"-policy, this series contains 3
patches, although they all have the same Fixes: tag.

Changes compared to v1:
  - Rebase on top of gpio array rework.
Patches applied, thanks Geert!
W.r.t. propagating errors: while gpiod_set_array_value_complex() and its
callers can now return an error code, this is currently limited to -ENOMEM.
Actual failures setting a GPIO output value cannot be propagated, as
gpio_chip.set() still returns void.  Do you want to change that?
E.g. gen_74x164_set_value() can fail.
I think we discussed it at one point and said that it's something
we should fix some day, just nobody has got around to do it.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help