On Sun, Sep 02, 2018 at 07:19:03PM -0700, Randy Dunlap wrote:

Date: Sun, 2 Sep 2018 19:19:03 -0700
From: Randy Dunlap <redacted>
To: Kenneth Lee <redacted>, Jonathan Corbet <corbet@lwn.net>,
 Herbert Xu [off-list ref], "David S . Miller"
 [off-list ref], Joerg Roedel [off-list ref], Alex Williamson
 [off-list ref], Kenneth Lee [off-list ref], Hao
 Fang [off-list ref], Zhou Wang [off-list ref], Zaibo Xu
 [off-list ref], Philippe Ombredanne [off-list ref], Greg
 Kroah-Hartman [off-list ref], Thomas Gleixner
 [off-list ref], linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
 iommu@lists.linux-foundation.org, kvm@vger.kernel.org,
 linux-accelerators@lists.ozlabs.org, Lu Baolu [off-list ref],
 Sanjay Kumar [off-list ref]
CC: linuxarm@huawei.com
Subject: Re: [PATCH 6/7] crypto: add sdmdev support to Hisilicon QM
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
Message-ID: [ref]

On 09/02/2018 05:52 PM, Kenneth Lee wrote:

quoted

diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index 1d155708cd69..b85fab48fdab 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig

@@ -17,6 +17,16 @@ config CRYPTO_DEV_HISI_SEC
 	  To compile this as a module, choose M here: the module
 	  will be called hisi_sec.
 
+config CRYPTO_DEV_HISI_SDMDEV
+	bool "Enable SDMDEV interface"
+	depends on CRYPTO_DEV_HISILICON
+	select VFIO_SDMDEV
+	help
+	  Enable this enable the SDMDEV, "shared IOMMU Domain Mediated Device"

At a minimum:
	  Enable this to enable the SDMDEV,

although that could be done better.  Maybe just:
	  Enable the SDMDEV "shared IOMMU Domain Mediated Device"

	  

quoted

+	  interface for all Hisilicon accelerators if they can. The SDMDEV

probably drop "if they can":          accelerators.  The SDMDEV interface

quoted

+	  enable the WarpDrive user space accelerator driver to access the

	  enables

Thank you, will change them all in the coming version.

quoted

+	  hardware function directly.
+

-- 
~Randy

-- 
			-Kenneth(Hisilicon)

================================================================================
本邮件及其附件含有华为公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁
止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中
的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！
This e-mail and its attachments contain confidential information from HUAWEI,
which is intended only for the person or entity whose address is listed above.
Any use of the 
information contained herein in any way (including, but not limited to, total or
partial disclosure, reproduction, or dissemination) by persons other than the
intended 
recipient(s) is prohibited. If you receive this e-mail in error, please notify
the sender by phone or email immediately and delete it!