On Mon, Aug 20, 2018 at 03:04:23PM -0700, Andi Kleen wrote:

On Mon, Aug 20, 2018 at 02:57:39PM -0700, Linus Torvalds wrote:

quoted

On Mon, Aug 20, 2018 at 1:37 PM Andi Kleen [off-list ref] wrote:

quoted

From: Andi Kleen <redacted>

Create a pgd_pfn() macro similar to the p[4um]d_pfn() macros and then
use the p[g4um]d_pfn() macros in the p[g4um]d_page() macros instead of
duplicating the code.

When doing backports, _please_ explicitly specify which commit this is
upstream too.

Ok.

quoted

Also, the original upstream patch is credited to Tom Lendacky.

Okay.

quoted

Or is there something I'm not seeing, and this is different from
commit fd7e315988b7 ("x86/mm: Simplify p[g4um]d_page() macros")?

No it's Tom's patch just ported to the older tree with some minor
changes. I just fat fingered it while doing the commit

Ok, I've fixed this up by hand now, please be more careful next time.

greg k-h