Thread (39 messages) 39 messages, 5 authors, 2018-08-10

Re: [RFC PATCH v2 04/12] mtd: rawnand: ams-delta: request data port GPIO resource

From: Linus Walleij <hidden>
Date: 2018-08-10 10:11:34
Also in: linux-arm-kernel, linux-gpio, linux-omap, lkml

On Tue, Aug 7, 2018 at 12:29 AM Janusz Krzysztofik [off-list ref] wrote:
Data port used by the driver is actually an OMAP MPUIO device, already
under control of gpio-omap driver.  For that reason we used to not
request the memory region of the port as that would fail because the
region is already busy.  Despite that, we are still accessing the port
by just ioremapping it and performing read/write operations.  Moreover,
we are doing that without any proteciton from other users legally
manipulating the port pins over GPIO API.

The plan is to convert the driver to access the port over functions
exposed by the gpio-omap driver.  Before that happens, already prevent
from other users accessing the port pins by requesting an array of its
GPIO descriptors.

Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com>
Reviewed-by: Linus Walleij <redacted>

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help