Re: [PATCH v13 0/7] cgroup-aware OOM killer
From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Date: 2018-08-01 22:01:42
Also in:
cgroups, linux-mm, lkml
On 2018/08/02 1:37, Roman Gushchin wrote:
On Tue, Jul 31, 2018 at 11:14:01PM +0900, Tetsuo Handa wrote:quoted
Can we temporarily drop cgroup-aware OOM killer from linux-next.git and apply my cleanup patch? Since the merge window is approaching, I really want to see how next -rc1 would look like...Hi Tetsuo! Has this cleanup patch been acked by somebody?
Not yet. But since Michal considers this cleanup as "a nice shortcut" ( https://marc.info/?i=20180607112836.GN32433@dhcp22.suse.cz ), I assume that I will get an ACK regarding this cleanup.
Which problem does it solve?
It simplifies tricky out_of_memory() return value decision, and it also fixes a bug in your series which syzbot is pointing out.
Dropping patches for making a cleanup (if it's a cleanup) sounds a bit strange.
What I need is a git tree which I can use as a baseline for making this cleanup. linux.git is not suitable because it does not include Michal's fix, but linux-next.git is not suitable because Michal's fix is overwritten by your series. I want a git tree which includes Michal's fix and does not include your series.
Anyway, there is a good chance that current cgroup-aware OOM killer implementation will be replaced by a lightweight version (memory.oom.group). Please, take a look at it, probably your cleanup will not conflict with it at all.
Then, please drop current cgroup-aware OOM killer implementation from linux-next.git . I want to see how next -rc1 would look like (for testing purpose) and want to use linux-next.git as a baseline (for making this cleanup).
Thanks!
-- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html