On 08/28/2018 07:10 PM, Linus Torvalds wrote:

On Tue, Aug 28, 2018 at 3:29 PM Waiman Long [off-list ref] wrote:

quoted

Yes, I can rewrite it. What is the problem with the abbreviated form?

Either gcc rewrites it for you, or you end up _actually_ using a
function pointer and calling through it.

Yes, function pointer will be really bad.

The latter would be absolutely horribly bad for something like
"list_add()", which should expand to just a couple of instructions.

And the former would be ok, except for the "you wrote code the garbage
way, and then depended on the compiler fixing it up". Which we
generally try to avoid in the kernel.

(Don't get me wrong - we definitely depend on the compiler doing a
good job at CSE and dead code elimination etc, but generally we try to
avoid the whole "compiler has to rewrite code to be good" model).

                 Linus

I see your point here. I will rewrite to use the regular if-then-else.

Thanks,
Longman