On 16/07/18 11:15 AM, Alex Williamson wrote:

quoted

+	pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ACS);
+	if (!pos) {
+		pci_warn(dev, "cannot disable ACS redirect for this hardware as it does not have ACS capabilities\n");
+		return;
+	}
+
+	if (!pci_dev_specific_disable_acs_redir(dev))
+		return;

Shouldn't this come before the above ACS capability test?  The PCH
quirk without a disable_acs_redir callback will fall out with the
pci_warn() above either way, but this ordering precludes that a quirk
could be written for that device since it doesn't have an ACS
capability.  Otherwise the series looks ok to me.  Thanks,

Yup, nice catch. I'll respin a v7 shortly.

Thanks,

Logan
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html