Re: [PATCH v5 3/5] PCI/AER: Add sysfs attributes to provide breakdown of AERs
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2018-06-22 17:27:39
Also in:
linux-pci, lkml
On Fri, Jun 22, 2018 at 12:38:50PM -0400, Tyler Baicar wrote:
On 6/21/2018 5:25 PM, Rajat Jain wrote:quoted
On Thu, Jun 21, 2018 at 11:48 AM, Bjorn Helgaas [off-list ref] wrote:quoted
[+cc Tyler for AER dmesg decoding] - Tyler posted a patch [1] to update those dmesg strings so they match the way lspci decodes them. I really liked that update, but we never quite finished it. If we're going to do that, it would be nice to do it first, so we don't publish new sysfs files, then immediately change the labels used in them.Sure, I guess you can push them in the right order.The way the prints are handled has already been unified in 4.18rc1: https://elixir.bootlin.com/linux/v4.18-rc1/source/drivers/pci/pcie/aer.c#L636 So that patch isn't needed anymore in it's entirety.quoted
quoted
- IIRC, Tyler's patch had the nice property of changing the strings so each error name had no spaces, which would make it a little easier to parse this sysfs file: each line would be a single identifier followed by a single number (I would probably remove the "=" from the middle).Will do.Would you like me to send a patch with just the string changes?
That would be awesome! Sorry, I didn't realize that half of that got done via another route. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html