On Tue, 5 Jun 2018 20:05:50 +0300
Andy Shevchenko [off-list ref] wrote:

On Tue, Jun 5, 2018 at 7:43 PM, Michal Suchanek [off-list ref]
wrote:

quoted

Hello,

due to work on the fadump_extra_args I looked at the kernel
parameter parser and found its grammar rather curious.

It supports double quotes but not any other quoting characters so
double quotes cannot be quoted. What's more, the quotes can be
anywhere in the parameter name or value and are interpteted but are
removed only from start and end of the parameter value.

These are the patches not specific to fadump which somewhat
straighten the qouting grammar to make it on par with common shell
interpreters.  

I didn't notice any use of string_unescape_*() functionality. So, your
patch is kinda very specific to some narrow subset of escaping and
unescaping stuff.

It does what it says. It cannot use string_unescape because it needs to
determine the boundaries of quoted strings.

Thus, it's still not on par with shell, right?

It does not interpret special character sequences other than quoting.

The feature would not be hard to add but I do not see the need.

Unfortunately, the existing string_unescape is totally not fitting to
be integrated into the parser for the purpose.

Thanks

Michal

quoted

Specifically double and single quotes can be used for quoting as
well as backslashes with the usual shell semantic. All quoting
characters are removed while the parameters are parsed.

--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html