Re: [PATCH v2 1/3] PCI: Make specifying PCI devices in kernel parameters reusable

On 01/06/18 04:39 AM, Andy Shevchenko wrote:

quoted

-       pci=option[,option...]  [PCI] various PCI subsystem options:
+       pci=option[,option...]  [PCI] various PCI subsystem options.
+
+                               Some options herein operate on a specific device
+                               or a set of devices (<pci_dev>). These are
+                               specified in one of two formats:

I would rather to add

 <pci_dev>

here in the same way as done for options.
It would be easy for people to find a referenced paragraph.

Sorry, I don't understand what you are asking. Can you be more specific?

quoted

+
+                               [<domain>:]<bus>:<slot>.<func>
+                               pci:<vendor>:<device>[:<subvendor>:<subdevice>]
+
+                               Note: the first format specifies a PCI
+                               bus/slot/function address which may change
+                               if new hardware is inserted, if motherboard
+                               firmware changes, or due to changes caused
+                               by other kernel parameters. The second format
+                               selects devices using IDs from the
+                               configuration space which may match multiple
+                               devices in the system.

quoted

+static int pci_dev_str_match(struct pci_dev *dev, const char *p,
+                            const char **endptr)

This change I hope has no functional alteration, so, can be split to a
separate patch.

That's all this patch does... Or do you want be to separate out
documentation from implementation? That just seems a bit excessive to me.

Logan
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html