Re: [PATCH 2/3] mm: replace __HAVE_ARCH_PTE_SPECIAL
From: David Rientjes <rientjes@google.com>
Date: 2018-04-09 20:08:41
Also in:
linux-arm-kernel, linux-mm, linux-riscv, linux-sh, linuxppc-dev, lkml, sparclinux
On Mon, 9 Apr 2018, Christoph Hellwig wrote:
quoted
-#ifdef __HAVE_ARCH_PTE_SPECIAL +#ifdef CONFIG_ARCH_HAS_PTE_SPECIAL # define HAVE_PTE_SPECIAL 1 #else # define HAVE_PTE_SPECIAL 0I'd say kill this odd indirection and just use the CONFIG_ARCH_HAS_PTE_SPECIAL symbol directly.
Agree, and I think it would be easier to audit/review if patches 1 and 3 were folded together to see the relationship between the newly added selects and what #define's it is replacing. Otherwise, looks good! -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html