Thread (4 messages) 4 messages, 2 authors, 2018-03-28

Re: [PATCH v12 07/22] selftests/vm: fixed bugs in pkey_disable_clear()

From: Dave Hansen <hidden>
Date: 2018-03-28 20:55:38
Also in: linux-arch, linux-kselftest, linux-mm, linuxppc-dev, lkml

On 03/28/2018 01:47 PM, Thiago Jung Bauermann wrote:
quoted
quoted
 	if (flags)
-		assert(rdpkey_reg() > orig_pkey_reg);
+		assert(rdpkey_reg() < orig_pkey_reg);
 }

 void pkey_write_allow(int pkey)
This seems so horribly wrong that I wonder how it worked in the first
place.  Any idea?
The code simply wasn't used. pkey_disable_clear() is called by
pkey_write_allow() and pkey_access_allow(), but before this patch series
nothing called either of these functions.
Ahh, that explains it.  Can that get stuck in the changelog, please?
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help