Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ARM: dts: microchip: redundant otpc status in sam9x60_curiosity.dts
--
commit 3ab977663934498a6526ef5c90d107058dabd158
Author: Alexander Dahl [off-list ref]
ARM: dts: microchip: sam9x60_curiosity: Enable OTP Controller
This commit sets status = "okay" on the &otpc node in
at91-sam9x60_curiosity.dts to enable the OTP controller on the SAM9X60
Curiosity board.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts b/arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts
index b9ffd9e5faacc..c110a8e87568a 100644
--- a/arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts
+++ b/arch/arm/boot/dts/microchip/at91-sam9x60_curiosity.dts
@@ -252,6 +252,10 @@ ethernet-phy@0 {
};
};
+&otpc {
+ status = "okay";
+};
[Severity: Medium]
Is this status override needed, or is status = "disabled" missing from the
base otpc node in arch/arm/boot/dts/microchip/sam9x60.dtsi?
In arch/arm/boot/dts/microchip/sam9x60.dtsi (added in commit 35ed4513c16e),
the otpc node is defined without a status property:
otpc: efuse@eff00000 {
compatible = "microchip,sama7g5-otpc", "syscon";
reg = <0xeff00000 0xec>;
#address-cells = <1>;
#size-cells = <1>;
clocks = <&pmc PMC_TYPE_CORE SAM9X60_PMC_MAIN_RC>, <&pmc PMC_TYPE_PERIPHERAL 46>;
};
Because __of_device_is_available() in drivers/of/base.c treats a node without
a status property as enabled by default, the OTP controller is already
enabled on all boards that include sam9x60.dtsi (such as at91-sam9x60ek.dts).
When mchp_otpc_probe() in drivers/nvmem/microchip-otpc.c probes the node, it
calls devm_clk_bulk_get_all_enabled(), keeping SAM9X60_PMC_MAIN_RC and
peripheral clock 46 permanently enabled.
Should otpc in sam9x60.dtsi have status = "disabled" by default so individual
boards opt in with status = "okay", or is this override in
at91-sam9x60_curiosity.dts redundant?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261105110715.2486432-1-ada@thorsis.com?part=15