Thread (35 messages) 35 messages, 5 authors, 10d ago

Re: [PATCH net-next v10 05/11] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

From: Coia Prant <hidden>
Date: 2026-09-24 05:19:48
Also in: linux-phy, sashiko-reviews

[off-list ref] 于2026年9月24日周四 04:05写道:
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] arm64: dts: missing required phys and phy-names in xpcs node
- [Low] arm64: dts: invalid status property in ethernet-pcs-mii subnodes
For the first point: dtbs_check skips required property validation for
disabled nodes, as confirmed by Rob Herring here:

https://lore.kernel.org/all/CAL_JsqJnOa_9Poz86vOWBCQigvv-Ab4Tt1hrwTxSa5zNraVxXQ@mail.gmail.com/ (local)

The xpcs node is disabled in the SoC dtsi, so phys and phy-names are
not required there. No change needed.

For the second point: status is a standard property that dt-validate
allows on all nodes, regardless of additionalProperties. Listing it in
properties are not required and not customary.

No changes needed.

Coia
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help