Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing type definition for vendor properties
--
commit e279d5a2991ae1467a7af717115f8a8656d5f101
Author: Daniel28972897 [off-list ref]
dt-bindings: misc: convert axis-fifo binding to YAML
This commit converts the text-based axis-fifo binding to a YAML schema to
enable validation via dtbs_check. It preserves all original properties,
including those generated by the Xilinx IP integrator that are currently
ignored by the Linux driver.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
new file mode 100644
index 0000000000000..fffd69b128111
--- /dev/null
+++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
[ ... ]
quoted hunk ↗ jump to hunk
+ # The following properties are generated by the Xilinx IP integrator
+ # for this core and may be present in real-world devicetrees, but are
+ # not currently read by the Linux driver.
+ xlnx,axi-str-rxd-protocol: true
+ xlnx,axi-str-txc-protocol: true
+ xlnx,axi-str-txc-tdata-width: true
+ xlnx,axi-str-txd-protocol: true
+ xlnx,axis-tdest-width: true
+ xlnx,axis-tid-width: true
[Severity: Low]
Does this properties block in
Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml pass make
dt_binding_check?
The dtschema meta-schema requires all custom vendor-specific properties to
have an explicitly defined type constraint (e.g.,
$ref: /schemas/types.yaml#/definitions/uint32).
Setting these vendor properties to true without mandatory $ref type
definitions or descriptions causes a build-time validation failure when
running make dt_binding_check on the added schema.
Will these properties be updated to include the appropriate type constraints?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260919025900.169703-1-danyboy28sep@gmail.com?part=1