Re: [PATCH v10 1/8] dt-bindings: iio: add Open Sensor Fusion device
flat view
From: sashiko-bot@kernel.org
Date: 2026-09-18 18:34:47
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] dt-bindings: generic compatible string without hardware identity -- commit 3fe2d4345189668d8fcaa5a3baad45cea6d48946 Author: Jinseob Kim [off-list ref] dt-bindings: iio: add Open Sensor Fusion device This commit adds a binding for the generic Open Sensor Fusion host interface. It defines a generic protocol stream over which capabilities and sensor channels are discovered at runtime, intentionally omitting the specific product identity (OSF GREEN) from the compatible string.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml b/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml new file mode 100644 index 0000000000000..3998390828cc0 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml
[ ... ]
quoted hunk ↗ jump to hunk
+properties: + compatible: + const: opensensorfusion,osf
[Severity: Medium] Does restricting the compatible string to this single generic protocol value prevent the kernel from handling future hardware-specific quirks, power sequencing requirements, or errata? The commit message explicitly states that the product identity (OSF GREEN) was intentionally omitted. Device Tree principles generally require describing the specific hardware rather than just the generic software protocol. Would it be better to require a hardware-specific compatible string here alongside the generic one, to ensure the binding can accommodate variations in future silicon? -- Sashiko AI review · https://sashiko.dev/#/patchset/cover.1789753020.git.kimjinseob88@gmail.com?part=1