Re: [PATCH 08/14] arm64: dts: apple: t6030: add avd nodes
From: sashiko-bot@kernel.org
Date: 2026-09-18 13:28:07
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] dt: undocumented compatible string apple,t6030-dart - [Low] dt: nodes avd and avd_dart are not sorted by unit address -- commit 1c295b9d0d2ddda136e588deb146546700501f9d Author: Sofus Forstreuter [off-list ref] arm64: dts: apple: t6030: add avd nodes This commit adds the avd and avd_dart nodes to the t6030 device tree.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/apple/t6030.dtsi b/arch/arm64/boot/dts/apple/t6030.dtsi index dda9568af11f9..802759a2352fa 100644 --- a/arch/arm64/boot/dts/apple/t6030.dtsi +++ b/arch/arm64/boot/dts/apple/t6030.dtsi@@ -361,6 +361,30 @@ pmgr_gfx: power-management@290e80000 { /* child nodes are added in t6030-pmgr.dtsi */ }; + avd: avd@30b080000 {
[Severity: Low] Does this node ordering violate the device tree convention of sorting nodes by unit address in ascending numerical order? The avd@30b080000 node is placed before the iommu@30b010000 node, which can trigger dtc W=1 warnings when building the device tree.
quoted hunk ↗ jump to hunk
+ compatible = "apple,t6030-avd", "apple,t8122-avd"; + reg = <0x3 0x0b080000 0x0 0x12000>, + <0x3 0x0b092000 0x0 0x12000>, + <0x3 0x0b0a4000 0x0 0x4000>, + <0x3 0x0b100000 0x0 0x10000>; + reg-names = "code", "sram", "mbox", "ctrl"; + interrupt-parent = <&aic>; + interrupts = <AIC_IRQ 788 IRQ_TYPE_LEVEL_HIGH>, + <AIC_IRQ 789 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&ps_avd_sys>; + resets = <&ps_avd_sys>; + iommus = <&avd_dart 0>; + }; + + avd_dart: iommu@30b010000 { + compatible = "apple,t6030-dart", "apple,t8110-dart";
[Severity: Low] Is the apple,t6030-dart compatible string missing from the dt-bindings documentation? Because the schema uses additionalProperties: false, the absence of this entry from Documentation/devicetree/bindings/iommu/apple,dart.yaml will cause a standard dtbs_check warning when validating the device tree.
quoted hunk ↗ jump to hunk
+ reg = <0x3 0x0b010000 0x0 0x4000>; + #iommu-cells = <1>; + interrupt-parent = <&aic>; + interrupts = <AIC_IRQ 795 IRQ_TYPE_LEVEL_HIGH>; + power-domains = <&ps_avd_sys>; + };
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260918-avd-v1-0-49977931f455@icloud.com?part=8