Re: [PATCH 2/3] platform: arm64: Add a driver for the EC found on ASUS Glymur machines

On 9/18/26 1:35 PM, Krzysztof Kozlowski wrote:

On Thu, Sep 17, 2026 at 12:54:57PM +0200, Konrad Dybcio wrote:

quoted

+static int asus_glymur_ec_resume(struct device *dev)
+{
+	return asus_glymur_ec_modern_standby(dev_get_drvdata(dev),
+					     ASUS_QCOM_EC_MODERN_STANDBY_EXIT);
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(asus_glymur_ec_pm_ops,
+				asus_glymur_ec_suspend,
+				asus_glymur_ec_resume);
+
+static const struct of_device_id asus_glymur_ec_of_match[] = {
+	{ .compatible = "asus,zenbook-a14-ux3407na-ec" },
+	{ .compatible = "asus,zenbook-a16-ux3607oa-ec" },

Does this mean devices are compatible? If so should be expressed in the
bindings. If not, should be expressed in bindings commit msg, see
writing bindings docs.

They generally seem to be, but because of the very limited information
we have, I don't think it's worth risking associating them.. Would
a mention of this be enough?

Konrad