Thread (12 messages) 12 messages, 4 authors, 16d ago

Re: [PATCH net-next v13 2/4] net: dsa: tag_ks8995: Add the KS8995 tag handling

From: Linus Walleij <linusw@kernel.org>
Date: 2026-09-14 20:42:08
Also in: sashiko-reviews

On Mon, Sep 14, 2026 at 9:57 PM [off-list ref] wrote:
Because there is no custom .flow_dissect override here, the DSA core falls
back to the generic flow dissector, which will use the 8-byte needed_headroom
as the RX tag length instead of 4 bytes.

Will this corrupt protocol extraction by skipping 8 bytes into the packet
instead of 4? This could cause the network core to read an invalid
encapsulated EtherType and break Receive Packet Steering (RPS), Transmit
Packet Steering (XPS), and Traffic Control (TC) rules on the conduit
interface.
That was actually a really interesting find so I send a v14 for
fixing this alone!

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help