Re: [PATCH v9 1/2] dt-bindings: rtc: Add pcf85053 support
From: sashiko-bot@kernel.org
Date: 2026-09-14 06:34:07
Also in:
linux-rtc
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] The schema definition for `interrupts` lacks a description indicating that the alarm interrupt is active-low level triggered, contradicting the commit message. - [Low] MAINTAINERS file changes are included in the dt-bindings patch despite the commit message claiming they were moved to the driver patch. -- commit fbacfc3b449475be8cfd2e294eee7d9182570611 Author: Lakshay Piplani [off-list ref] dt-bindings: rtc: Add pcf85053 support This commit adds device tree bindings for the NXP PCF85053 RTC chip.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml b/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml new file mode 100644 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml
[ ... ]
+ reg: + maxItems: 1 + + interrupts: + maxItems: 1 +
[Severity: Low] Does this property definition need an explicit description? The V8 -> V9 changelog states "Describe the alarm interrupt as active-low level triggered," but this definition only contains maxItems: 1. While the example at the bottom of the schema correctly uses IRQ_TYPE_LEVEL_LOW, the property itself lacks the promised description text. [ ... ]
quoted hunk ↗ jump to hunk
diff --git a/MAINTAINERS b/MAINTAINERS --- a/MAINTAINERS +++ b/MAINTAINERS@@ -19571,6 +19571,13 @@ S: Maintained F: Documentation/devicetree/bindings/extcon/extcon-ptn5150.yaml F: drivers/extcon/extcon-ptn5150.c +NXP RTC PCF85053 DRIVER +M: Pankit Garg <pankit.garg@nxp.com> +M: Lakshay Piplani <lakshay.piplani@nxp.com> +L: linux-rtc@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/rtc/nxp,pcf85053.yaml +
[Severity: Low] Should these MAINTAINERS file changes be included in this dt-bindings patch? The V2 -> V3 changelog claims "Moved MAINTAINERS file changes to the driver patch", but this patch still introduces the new section. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260914062048.3704059-1-lakshay.piplani@nxp.com?part=1