Thread (8 messages) flat view 8 messages, 4 authors, 10d ago

Re: [PATCH 1/3] regulator: dt-bindings: mps,mpq4210: Use the -ohms unit suffix

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-09-14 06:14:36
Also in: lkml

On 13/09/2026 13:40, Tapio Reijonen wrote:
The feedback divider property was added without the standard unit
suffix. Rename mps,fb-voltage-divider to mps,fb-voltage-divider-ohms.

The suffix is worth more here than the convention alone: mps,mp886x.yaml
already describes a property of the exact same name whose values are in
kilo ohms, so two bindings from the same vendor spelled the resistances
identically while meaning different units. The suffix states the unit
where it cannot be missed.

Drop the explicit uint32-array $ref along with the rename. Properties
ending in -ohms are typed by property-units.yaml, which reports the type
error itself, so restating it only produced a duplicate complaint.

The binding has not appeared in a release and has no in-tree users, so
nothing depends on the old name. The driver is updated in the next patch.

Fixes: e3c05a881fc9 ("regulator: dt-bindings: Add MPS MPQ4210")
Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20260911-gaur-of-satisfying-action-1a3b0f@quoll (local)
Signed-off-by: Tapio Reijonen <redacted>
---
 Documentation/devicetree/bindings/regulator/mps,mpq4210.yaml | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help