Re: [PATCH 2/2] phy: renesas: Add Renesas Multi-Protocol PHY driver for R-Car X5H

On 9/3/26 12:15 PM, Manivannan Sadhasivam wrote:

Hello Manivannan,

quoted

+/* Firmware update */
+#define MPPHY_FW_BASE			0x10000
+#define MPPHY_FW_CH_OFFSET		0x20000
+#define MPPHY_FW_NAME			"rcar_gen5_mp_phy.bin"

Is this firmware redistributable? I would assume not as like other Renesas IP
firmware. If so, you should add a documentation about how an user can get the
firmware, and package it. Like,
Documentation/PCI/controller/rcar-pcie-firmware.rst

I will do so in V2 .

The Gen4 firmware is now part of linux-firmware, so I updated that piece 
of documentation and sent a patch.

[...]

quoted

+static int mp_phy_probe(struct platform_device *pdev)
+{

[...]

quoted

+	return pm_runtime_resume_and_get(dev);

Since the runtime usage count is incremented and not dropped anywhere else, the
driver will never runtime suspend.

quoted

+}

I do not think we can actually runtime suspend the PHY itself, so this 
is expected.

The rest of the feedback is handled in V2, thank you !

-- 
Best regards,
Marek Vasut