Re: [PATCH] ASoC: dt-bindings: Use consistent indentation in the example
From: sashiko-bot@kernel.org
Date: 2026-09-13 12:36:44
Also in:
imx
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Undocumented modification of node name and removal of node label in cirrus,cs42l42.yaml. -- commit 5295b0f4ddd7e74d1f23eafb35de82eb0e0a7330 Author: Krzysztof Kozlowski [off-list ref] ASoC: dt-bindings: Use consistent indentation in the example This commit corrects indentation in several DT binding examples to use consistent 2- or 4-spaces spacing, resolving dt-check-style warnings. The commit message also notes a generic node name correction specifically for dialog,da7219.yaml. [ ... ]
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml index af599d8735e26..ab4c7d22dc0eb 100644 --- a/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml@@ -199,28 +199,28 @@ examples: - | #include <dt-bindings/sound/cs42l42.h> i2c { - #address-cells = <1>; - #size-cells = <0>; - - cs42l42: cs42l42@48 { + #address-cells = <1>; + #size-cells = <0>; + + audio-codec@48 {
[Severity: Low] The commit message explicitly notes: "While changing the lines, correct also node name to be generic in dialog,da7219.yaml." Does this patch unintentionally also rename the node and drop the label here in cirrus,cs42l42.yaml without documenting it in the commit message?
- compatible = "cirrus,cs42l42"; - reg = <0x48>;
[ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260913123234.99988-2-krzysztof.kozlowski@oss.qualcomm.com?part=1