RE: [PATCH 4/5] arm64: dts: fsd: Re-order nodes to match coding style
From: "Alim Akhtar" <alim.akhtar@samsung.com>
Date: 2026-09-11 02:18:45
Also in:
linux-arm-kernel, linux-samsung-soc, lkml
-----Original Message----- From: Krzysztof Kozlowski <redacted> Sent: Wednesday, September 9, 2026 7:48 PM To: Alim Akhtar <alim.akhtar@samsung.com>; linux-fsd@tesla.com; Krzysztof Kozlowski [off-list ref]; Peter Griffin [off-list ref]; Rob Herring [off-list ref]; Conor Dooley [off-list ref] Cc: linux-arm-kernel@lists.infradead.org; linux-samsung- soc@vger.kernel.org; devicetree@vger.kernel.org; linux- kernel@vger.kernel.org; Krzysztof Kozlowski [off-list ref] Subject: [PATCH 4/5] arm64: dts: fsd: Re-order nodes to match coding style Re-order several top-level and MMIO nodes to match coding style - ordering by name or by unit address, as pointed out by dt-check-style, e.g.: fsd.dtsi:981: [child-address-order] child node @10040000 out of address order fsd.dtsi:315: [child-name-order] child node 'arm-pmu' out of name order fsd.dtsi:348: [child-name-order] child node 'clock' out of name order While moving chunks of code, also re-order a few properties (I2S, SPI and CAN nodes) to fix: fsd.dtsi:661: [property-order] property 'clocks' out of canonical order (should sort before 'samsung,syscon-phandle') fsd.dtsi:936: [property-order] property 'pinctrl-names' must be placed after 'pinctrl-0' fsd.dtsi:936: [property-order] property 'pinctrl-names' out of canonical order (should sort before 'samsung,spi-src-clk') Moving several nodes already creates unreviewable commit, thus reshuffling the properties allows to skip changing the same line twice without loss of readability. Signed-off-by: Krzysztof Kozlowski [off-list ref] ---
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>