Thread (7 messages) flat view 7 messages, 3 authors, 7d ago

Re: [PATCH 1/2] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

From: sashiko-bot@kernel.org
Date: 2026-09-10 22:19:03

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] The $id field in the YAML binding schemas for ti,omap2-aes and ti,omap4-des lacks the required 'crypto/' subdirectory path component, breaking schema cross-referencing.
--

commit c96c7ea0473045fc72e713eb6392d7342cfcdd4f
Author: Bhargav Joshi [off-list ref]

ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

This patch removes the "clocks" and "clock-names" properties from the
omap-sham and omap-aes nodes in the dra7 device tree. The crypto
drivers do not use these properties, and their dt-bindings do not define
them, which currently causes dtbs_check warnings.
    The omap-sham and omap-aes crypto drivers do not use "clocks" and
    "clock-names" properties. Clock management is handled by the ti-sysc
    interconnect parent wrapper. The dt-bindings for ti,omap-sham and
    ti,omap-aes don't define these clock properties. Having them in the
    child nodes causes dtbs_check warnings.
[Severity: Low]
This is a pre-existing issue, but the $id fields in the YAML binding schemas
for ti,omap2-aes and ti,omap4-des lack the required 'crypto/' subdirectory
path component.

For example, in Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml:

  $id: http://devicetree.org/schemas/ti,omap2-aes.yaml#

And in Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml:

  $id: http://devicetree.org/schemas/ti,omap4-des.yaml#

Could this break schema cross-referencing ($ref) and cause dt_binding_check
to report misleading errors or skip validation?

Should these files be updated to include the crypto/ subdirectory path
component?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-ti-dra7-omap-sham-fix-v1-0-c430f01b4e13@gmail.com?part=1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help