Re: [PATCH net-next v3 1/4] dt-bindings: net: realtek,rtl9301-mdio: Add clock-frequency
From: netdev-bot+sashiko@kernel.org
Date: 2026-09-10 15:04:31
Also in:
netdev
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: Critical: 0 · High: 0 · Medium: 0 · Low: 1 - [Low] The binding documents `clock-frequency` (with `default: 2500000` and per-family enums) for the `mdio-bus@N` children of the Realtek… -- dt-bindings: net: realtek,rtl9301-mdio: Add clock-frequency This documents a clock-frequency property on the mdio-bus@N child nodes of the Realtek Otto switch MDIO controller, with a default of 2500000 and per-family allowed value sets expressed through new allOf if-then blocks. No clock reference is added, since the setup bits are not documented as dividers. No Link: tags are present in the commit header.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml b/Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml index 67e0b23a8470..88502d017eed 100644 --- a/Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml +++ b/Documentation/devicetree/bindings/net/realtek,rtl9301-mdio.yaml@@ -56,6 +56,9 @@ patternProperties: reg: maxItems: 1 + clock-frequency: + default: 2500000 + required: - reg
[ ... ] No regressions found in this patch. One item was checked and dismissed: at this commit there is no consumer of clock-frequency, since otto_emdio_probe_one() in drivers/net/mdio/mdio-realtek-rtl9300.c reads only reg. The driver side arrives later in the same series with "net: mdio: realtek-rtl9300: Support non-default clock frequency", which does: if (of_property_read_u32(node, "clock-frequency", &freq)) freq = 2500000; err = priv->info->set_bus_frequency(bus, freq); so the default of 2500000 and the per-family value sets documented here are honoured by the end of the series. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260909150107.3602067-1-markus.stockhausen%40gmx.de