Re: [PATCH 4/6] dt-bindings: interrupt-controller: apple,aic2: Add apple,t8140 compatible

On 09/09/2026 09:34, Yureka Lilian wrote:

quoted

quoted

quoted

quoted

diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
index 1cb886785173..e3cadc5ad39d 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml

@@ -46,6 +46,7 @@ properties:
                - apple,t6030-aic3
                - apple,t6031-aic3
                - apple,t8132-aic3
+              - apple,t8140-aic3

the title should be "... Add t8140 compatible" describing the hardware corresponding
to the added compatible since the compatible being added is not "apple,t8140".

Commit msg is correct, it does exactly what you wrote, no?

quoted

(Alternatively, if you mention the compatible in title, say "...Add apple,t8140-aic3" as
"compatible" is already implied)

That would be repeating diff, so not really helpful.

Ah, you meant the subject of the patch...


Best regards,
Krzysztof

That's how I parsed it too. Removed the "apple," from the subject, so 
it's just "dt-bindings: interrupt-controller: apple,aic2: Add t8140 
compatible".

Sure

Best regards,
Krzysztof