Thread (9 messages) flat view 9 messages, 4 authors, 2d ago

Re: [PATCH 2/2] mfd: qcom-pm8008: support PMICs with no interrupt line

From: sashiko-bot@kernel.org
Date: 2026-09-08 13:15:22

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized, violating MFD subsystem guidelines.
--

commit 18efba6bffe886fb1172493d0880293e52f677a5
Author: Oleg Keri [off-list ref]

mfd: qcom-pm8008: support PMICs with no interrupt line

This commit updates the qcom-pm8008 driver to allow probing PMICs without an
interrupt line. It skips IRQ chip registration if the interrupt is absent and
registers only the regulator cell, since the temperature alarm and GPIO cells
require an IRQ domain.
mfd: qcom-pm8008: support PMICs with no interrupt line
[Severity: Low]
This isn't a bug, but does this commit message subject line follow the MFD
subsystem formatting guidelines? The documentation requires capitalizing the
description after the subsystem prefix, so "support" should likely be changed
to "Support".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908130745.2545-1-okerixx@gmail.com?part=2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help