Re: [PATCH v6 1/6] dt-bindings: display: verisilicon,dc: add support for nuvoton,ma35d1-dcu
From: sashiko-bot@kernel.org
Date: 2026-09-08 09:36:29
Also in:
dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The schema fails to restrict the `ports` property to prevent `port@1` for the `nuvoton,ma35d1-dcu` compatible, despite the hardware only having a single output port. -- commit aa050e9da3d62c01f3875ac6fea01c9b0fc78e94 Author: Joey Lu [off-list ref] dt-bindings: display: verisilicon,dc: add support for nuvoton,ma35d1-dcu This commit adds support for the Nuvoton MA35D1 DCUltraLite in the verisilicon,dc binding. It adjusts the global minimum clocks and resets, and applies specific topology limits for supported variants via an allOf block.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml --- a/Documentation/devicetree/bindings/display/verisilicon,dc.yaml +++ b/Documentation/devicetree/bindings/display/verisilicon,dc.yaml
[ ... ]
quoted hunk ↗ jump to hunk
@@ -79,6 +84,45 @@ required:
[ ... ]
quoted hunk ↗ jump to hunk
+ - if: + properties: + compatible: + contains: + const: nuvoton,ma35d1-dcu + then: + properties: + clocks: + maxItems: 4 + + clock-names: + maxItems: 4 + + resets: + maxItems: 1 + + reset-names: + maxItems: 1
[Severity: Low] Does this conditional block also need to restrict the ports property? The commit message notes that the DCUltraLite has a single output port, but the schema doesn't restrict port@1 from being used for the nuvoton,ma35d1-dcu compatible. Without disallowing the non-existent second output port here, an invalid device tree specifying port@1 would silently pass static schema validation. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260908092840.225220-1-a0987203069@gmail.com?part=1