Re: [PATCH v2 2/2] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640
From: sashiko-bot@kernel.org
Date: 2026-09-08 07:11:28
Also in:
linux-hwmon
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added devices RAA229639 and RAA229640 are not documented in the supported chips list. -- commit 1702c94b50317002cdd0b95f06c65c3af4214d35 Author: Colin Huang [off-list ref] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640 This commit adds support for the Renesas RAA229639 and RAA229640 PMBus voltage regulator devices. It updates the existing raa_dmpvr2_2rail driver variant by adding the corresponding device IDs and OF match entries.
quoted hunk ↗ jump to hunk
diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c index 2f7f825bfb69e..53b44775ba1e6 100644 --- a/drivers/hwmon/pmbus/isl68137.c +++ b/drivers/hwmon/pmbus/isl68137.c@@ -456,6 +456,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = { { .name = "raa229004", .driver_data = raa_dmpvr2_2rail }, { .name = "raa229141", .driver_data = raa_dmpvr2_2rail_pmbus }, { .name = "raa229621", .driver_data = raa_dmpvr2_2rail }, + { .name = "raa229639", .driver_data = raa_dmpvr2_2rail }, + { .name = "raa229640", .driver_data = raa_dmpvr2_2rail },
[Severity: Low] Since these new devices are being added to the driver, should they also be documented in the "Supported chips" list within Documentation/hwmon/isl68137.rst alongside the existing parts? [ ... ] -- Sashiko AI review · https://sashiko.dev/#/patchset/20260908-add-raa229639-and-raa229640-v2-0-83c75b61139d@gmail.com?part=2