Re: [PATCH v2 08/11] ASoC: SDCA: make find_sdca_control_reset() return void

From
Srinivas Kandagatla <hidden>
Date
2026-09-07 13:16:40
Also in
linux-arm-msm, linux-sound, lkml
Reply to
Charles Keepax, 2026-09-07
On 9/7/26 2:03 PM, Charles Keepax wrote:
On Mon, Sep 07, 2026 at 01:32:30PM +0200, Pierre-Louis Bossart wrote:
quoted
On 9/7/26 10:37, Srinivas Kandagatla wrote:
quoted
find_sdca_control_reset() only ever returns 0 -- it just sets
control->has_reset / control->reset for the framework-known
(entity type, control selector) mappings.  The int return + caller
error check in find_sdca_entity_control() are dead code.

Convert to void and drop the check.  No functional change.

Signed-off-by: Srinivas Kandagatla <redacted>
That looks also unrelated to DT stuff, not sure it belongs here as patch
08/11

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
Agree lets pull these two patches out and submit seperately as we
can merge them both happily today.
Thanks Charles, Sure let me send them out separately.
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
--srini
Thanks,
Charles
  
Thread (50 messages) 50 messages, 8 authors, last reply 2026-09-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help