Re: [PATCH v2 2/2] arm64: dts: qcom: lemans-evk: Add Raspberry Pi 7-inch DSI panel overlay
From: sashiko-bot@kernel.org
Date: 2026-09-07 06:44:03
Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider: - [Low] Downstream-only I2C properties (`qcom,load-firmware` and `qcom,xfer-mode`) are leaked into the upstream device tree. - [Low] The panel node is missing the mandatory fallback compatible for the ILI9881c driver. - [Low] The regulator MCU node uses an invalid node name and includes an unsupported vcc-supply property. -- commit c29fa706b8fbecd36dcc880f57d516cffcc9f530 Author: Shashank Maurya [off-list ref] arm64: dts: qcom: lemans-evk: Add Raspberry Pi 7-inch DSI panel overlay This commit adds a device tree overlay for the Raspberry Pi 7" DSI touchscreen panel on Lemans EVK. It configures mdss0_dsi0 with 2 data lanes and adds the panel MCU on I2C1.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-raspberrypi-dsi-7inch.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-raspberrypi-dsi-7inch.dtso new file mode 100644 index 0000000000000..14743b3c38637 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/lemans-evk-raspberrypi-dsi-7inch.dtso
[ ... ]
+&i2c1 {
+ qcom,load-firmware;
+ qcom,xfer-mode = <1>;[Severity: Low] Are these downstream I2C properties intended to be included in the upstream device tree? They do not exist in the upstream devicetree bindings and are not parsed by mainline drivers, which will cause schema validation errors during make dtbs_check.
+
+ status = "okay";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ reg_backlight: reg_backlight@45 {[Severity: Low] Does this node name violate the expected naming convention? It seems it should match the ^regulator(@.*)?$ pattern inherited from regulator.yaml to avoid dtbs_check schema validation errors.
+ compatible = "raspberrypi,touchscreen-panel-regulator-v2"; + reg = <0x45>; + + vcc-supply = <®_dsi_touch>;
[Severity: Low] Is this vcc-supply property supported by the binding? The raspberrypi,7inch-touchscreen-panel-regulator-v2.yaml specifies additionalProperties: false and does not define vcc-supply. Since the panel explicitly enables reg_dsi_touch anyway, should this be removed to pass schema validation?
+ gpio-controller;
+ #gpio-cells = <2>;
+ #pwm-cells = <3>;
+ };
+};
+
+&mdss0_dsi0 {
+ vdda-supply = <&vreg_l1c>;
+
+ status = "okay";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "raspberrypi,dsi-7inch";[Severity: Low] Is this missing the mandatory fallback compatible for the ILI9881c driver? According to Documentation/devicetree/bindings/display/panel/ilitek,ili9881c.yaml, this should be an array of two strings containing the specific panel and the fallback ilitek,ili9881c.
+ reg = <0>;
-- Sashiko AI review · https://sashiko.dev/#/patchset/20260907-rpi_dts_overlay-v2-0-a4989322ce00@oss.qualcomm.com?part=2