Re: [PATCH net-next v7 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema
From: sashiko-bot@kernel.org
Date: 2026-09-05 12:36:29
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Mismatch between v5 changelog claim and actual implementation regarding the `interrupts` property. -- commit 71f148f5cb00ff21bcdd03a6c89a26a42be35836 Author: Arthur Crepin Leblond [off-list ref] dt-bindings: net: wiznet,w5100: convert to DT schema This commit converts the Wiznet w5x00 SPI Ethernet controller binding from plain text to DT schema.
--- v6: - Put back the reviewed by tag from Krzysztof Kozlowski from v4 v5: - Remove gpio/gpio.h include from DT example - Make the DT interrupts property dynamic from the compatible one - Fix DT bindings errors
[ ... ]
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/wiznet,w5100.yaml b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml new file mode 100644 index 0000000000000..601d828bae927 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wiznet,w5100.yaml
[ ... ]
+ spi-max-frequency: + description: + According to the w5500 datasheet, the chip allows a maximum of 80 MHz, + however, board designs may need to limit this value. + maximum: 80000000 + +required: + - compatible + - reg + - interrupts
[Severity: Low] The v5 changelog notes mention making the interrupts property dynamic based on the compatible string, but it remains unconditionally required here in the global required block. Is the changelog description out of date, or was the dynamic property logic unintentionally dropped from the schema during a rebase? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260904-wiznet-link-gpio-v7-0-69f01b70c96f@marmottus.net?part=1