Re: [PATCH v3 1/5] dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The 'gpio-controller' and '#gpio-cells' properties were added to the binding to document GPIO provider capabilities, but were not added to the 'required' list.
--

commit 167159eda5a6932cbffa6730117f8dd7e23b2970
Author: Lorenzo Bianconi [off-list ref]

dt-bindings: PCI: toshiba,tc9563: Document embedded GPIO controller

This commit documents the embedded GPIO controller within the TC9563 PCIe
switch. It adds gpio-controller and #gpio-cells properties to the device
tree binding, along with the reset-gpios property for the downstream port.

quoted

diff --git a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
index f084830c6d0cb..c4cd162cb084b 100644
--- a/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml
+++ b/Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml

@@ -31,6 +31,11 @@ properties:
     description:
       GPIO controlling the RESX# pin.
 
+  gpio-controller: true
+
+  '#gpio-cells':
+    const: 2
+

[Severity: Medium]
Should gpio-controller and #gpio-cells be added to the required list?

Looking at the required list in
Documentation/devicetree/bindings/pci/toshiba,tc9563.yaml around line 108,
these newly added GPIO provider capabilities are missing:

required:
  - resx-gpios
  - vdd18-supply
  - vdd09-supply
  - vddc-supply

Without being added to the required list, device trees with incomplete
configurations (missing the newly added GPIO controller properties) will
silently pass schema validation when running dt_binding_check or dtbs_check.

ack, I will fix it in v4.

Regards,
Lorenzo

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-pci-tc9563-aux-v3-0-5b1449d62ba2@oss.qualcomm.com?part=1