Re: [PATCH v8 08/11] arm64: dts: renesas: add support for solidrun hb-ripple with rzg2l som
From: sashiko-bot@kernel.org
Date: 2026-09-04 12:10:47
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The shared device tree include file `rzg2l-hummingboard-pulse-common.dtsi` uses LED subsystem macros without including the required header, breaking self-containment. -- commit d997057daebf169901ade156154724f6370de654 Author: Josua Mayer [off-list ref] arm64: dts: renesas: add support for solidrun hb-ripple with rzg2l som Add support for the SolidRun HummingBoard Ripple with RZ/G2L SoM, which is a reduced version of HummingBoard Pulse featuring various connectors like USB, Ethernet, micro-HDMI, and microSD.
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-pulse-common.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-pulse-common.dtsi new file mode 100644 index 0000000000000..b0ddd426241ab --- /dev/null +++ b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-pulse-common.dtsi
[ ... ]
+&phy0 {
+ leds {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@0 {
+ reg = <0>;
+ color = <LED_COLOR_ID_ORANGE>;
+ default-state = "keep";
+ function = LED_FUNCTION_LAN;
+ };
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_GREEN>;
+ default-state = "keep";
+ function = LED_FUNCTION_LAN;
+ };
+ };
+};[Severity: Low] Should this file include dt-bindings/leds/common.h directly to remain self-contained? The led@0 and led@1 nodes use LED_COLOR_ID_ORANGE, LED_COLOR_ID_GREEN, and LED_FUNCTION_LAN, but the header defining these macros is not included here. [ ... ]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi new file mode 100644 index 0000000000000..5e043e40641a6 --- /dev/null +++ b/arch/arm64/boot/dts/renesas/rzg2l-hummingboard-ripple.dtsi@@ -0,0 +1,127 @@ +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +/* + * Copyright 2025 Josua Mayer <josua@solid-run.com> + */ + +#include <dt-bindings/leds/common.h> + +#include "rzg2l-hummingboard-pulse-common.dtsi"
[Severity: Low] Does rzg2l-hummingboard-pulse-common.dtsi rely on this include being placed before it? If a future device tree includes rzg2l-hummingboard-pulse-common.dtsi without also including dt-bindings/leds/common.h beforehand, the build will fail due to the undefined LED subsystem macros. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260904-rzg2-sr-boards-v8-0-94c4674927e8@solid-run.com?part=8