Re: [PATCH v4 1/4] firmware: raspberrypi: reorder rpi_firmware_property_tag enum
From: Gregor Herburger <hidden>
Date: 2026-09-04 11:11:31
Also in:
sashiko-reviews
On Fri, Sep 04, 2026 at 07:51:08AM +0000, sashiko-bot@kernel.org wrote:
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The patch claims to reorder the `rpi_firmware_property_tag` enum by tag values but introduces a new sorting error by moving higher values immediately before lower ones. -- commit 5b5e3e4d76c8fceb817f997acacf1b16bf561c0e Author: Gregor Herburger [off-list ref] firmware: raspberrypi: reorder rpi_firmware_property_tag enum This patch reorders the tags in the rpi_firmware_property_tag enum to sort them by their tag values. It claims no functional change is intended.quoted
diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h index 975bef529854a..8ad1cdbf5e9f5 100644 --- a/include/soc/bcm2835/raspberrypi-firmware.h +++ b/include/soc/bcm2835/raspberrypi-firmware.h[ ... ]quoted
@@ -125,10 +125,10 @@ enum rpi_firmware_property_tag { RPI_FIRMWARE_FRAMEBUFFER_SET_VIRTUAL_OFFSET = 0x00048009, RPI_FIRMWARE_FRAMEBUFFER_SET_OVERSCAN = 0x0004800a, RPI_FIRMWARE_FRAMEBUFFER_SET_PALETTE = 0x0004800b, - RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF = 0x0004801f, - RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF = 0x00048020, RPI_FIRMWARE_FRAMEBUFFER_SET_VSYNC = 0x0004800e, RPI_FIRMWARE_FRAMEBUFFER_SET_BACKLIGHT = 0x0004800f, + RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF = 0x0004801f, + RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF = 0x00048020, RPI_FIRMWARE_VCHIQ_INIT = 0x00048010,[Severity: Medium] The commit message mentions that the enum is being ordered by tag values, but does this actually break the ordering for these values? The new placement moves RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF (0x0004801f) and RPI_FIRMWARE_FRAMEBUFFER_SET_GPIOVIRTBUF (0x00048020) immediately before RPI_FIRMWARE_VCHIQ_INIT (0x00048010) in rpi_firmware_property_tag.
Yes I am aware of this but this RPI_FIRMWARE_VCHIQ_INIT seems not to fit into the RPI_FIRMWARE_FRAMEBUFFER_* block. So I decided to keep it where it is. Best regards -- Gregor Herburger Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen Phone: +49 7556 25 999 35; Fax.: +49 7556 25 999 99 Hinweise zum Datenschutz finden Sie hier (Informations on data privacy can be found here): https://linutronix.de/legal/data-protection.php Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 806 | Geschäftsführer (Managing Directors): Dr. Wilfried Wessner, Katharina Kopp, Alexander Gieringer