Re: [PATCH v2 2/3] nvmem: uniphier-efuse: Enable for K3 SoCs
From: sashiko-bot@kernel.org
Date: 2026-09-02 22:39:00
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Kconfig change fails to enforce the 'must be builtin' requirement for K3 architecture. -- commit 748ef11d98132dda0086b8cea5abfe1449a55b52 Author: Judith Mendez [off-list ref] nvmem: uniphier-efuse: Enable for K3 SoCs This commit adds ARCH_K3 as a dependency for the UniPhier eFuse driver and sets it to default 'y'. The intention is to ensure it is built-in to support early probe of k3-socinfo during boot.
quoted hunk ↗ jump to hunk
diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index 283134498fbc3..192e9617ec472 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig@@ -376,8 +376,9 @@ config NVMEM_U_BOOT_ENV config NVMEM_UNIPHIER_EFUSE tristate "UniPhier SoCs eFuse support" - depends on ARCH_UNIPHIER || COMPILE_TEST + depends on ARCH_UNIPHIER || ARCH_K3 || COMPILE_TEST depends on HAS_IOMEM + default y if ARCH_K3
[Severity: Medium] Does this configuration actually guarantee the driver is built-in? The commit message notes that the uniphier-efuse driver must be built-in to support early probe of k3-socinfo. However, because NVMEM_UNIPHIER_EFUSE is a tristate option, using `default y if ARCH_K3` only provides a default value. It leaves the option vulnerable to being configured as a module (CONFIG_NVMEM_UNIPHIER_EFUSE=m) by users or automated CI builds like allmodconfig, which would break the early boot probe dependency. -- Sashiko AI review · https://sashiko.dev/#/patchset/20260902222759.736124-1-jm@ti.com?part=2