Re: [PATCH v1 04/11] dt-bindings: soc: qcom: add binding for qcom,crypto-virt
flat view
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-08-31 07:01:51
Also in:
linux-arm-msm, linux-block, linux-crypto, linux-scsi, lkml, virtualization
On 27/08/2026 18:07, Linlin Zhang wrote:
From: linlzhan <redacted> Document the device tree binding for the Qualcomm GVM crypto-virt node, which provides the wrapped-key buffer size needed by the QCOM_CRYPTO_VIRT driver to perform hardware-wrapped-key SCM operations backing virtio_blk's inline crypto layer. The host does not report this size over virtio, so it is supplied via DT through the optional qcom,wrapped-key-size property. Signed-off-by: linlzhan <redacted>
Your Git does not look like properly configured.
quoted hunk ↗ jump to hunk
--- .../bindings/soc/qcom/qcom,crypto-virt.yaml | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,crypto-virt.yamldiff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,crypto-virt.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,crypto-virt.yaml new file mode 100644 index 000000000000..5eb204f29762 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,crypto-virt.yaml@@ -0,0 +1,39 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/qcom/qcom,crypto-virt.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: QCOM GVM Crypto Virt driver
We do not take bindings for drivers. Follow standard rules for bindings, e.g. read DTS101 slides. Also: drop second/last, redundant "binding for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23 Just describe the hardware (not drivers) Best regards, Krzysztof